Apply maximum block size limit during bloom compaction #11681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
salvacorts
force-pushed
the
salvacorts/max-size-bloom-blocks
branch
from
c416b19 to
e77de93
Compare
chaudum
reviewed
Jan 18, 2024
| @@ -54,6 +57,7 @@ func NewBlockBuilder(opts BlockOptions, writer BlockWriter) (*BlockBuilder, erro | |||
|
|
|||
| return &BlockBuilder{ | |||
| opts: opts, | |||
| writer: writer, | |||
There was a problem hiding this comment.
As far as I see, the writer is only used to determine the size of the block after each population cycle.
Instead of adding the writer to the block builder, could we just use an int type that stores the current size?
There was a problem hiding this comment.
To get the Size you need access to the writer. I don't think we can just have an in in the builder, how would you set that int without access to the writer?
|
Closing in favor of #11878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new per-tenant limit
bloom_compactor_max_block_sizethat adjusts the maximum size of the bloom blocks the bloom-compactor builds. By default this limit is unset so blocks can be arbitrarily big.The block builder keeps adding series' blooms to a block until the limit is exceeded, meaning that blocks may grow beyond the configured maximum. This is needed so we avoid having tiny blocks which had space for small blooms but later a bigger blooms didn't fit.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR